adding docker upgrade rollout strategy #7315
Conversation
eks-distro-bot
added
the
size/L
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7315 +/- ##
=======================================
Coverage 71.72% 71.72%
=======================================
Files 559 559
Lines 43368 43377 +9
=======================================
+ Hits 31104 31113 +9
Misses 10549 10549
Partials 1715 1715 ☔ View full report in Codecov by Sentry. |
pkg/providers/docker/docker_test.go
Outdated
| @@ -327,6 +327,38 @@ func TestProviderGenerateDeploymentFileSuccessUpdateMachineTemplate(t *testing.T | |||
| wantCPFile: "testdata/valid_deployment_cp_expected.yaml", | |||
| wantMDFile: "testdata/valid_autoscaler_deployment_md_expected.yaml", | |||
| }, | |||
| { | |||
| testName: "valid config with rollout", | |||
There was a problem hiding this comment.
I'll leave it up to you but I would prefer if we tested these things through ControlPlaneSpec and WorkersSpec
That decouples the tests from the fact that these spec builders return yaml (which they should never have)
I understand you are just following whatever was in here, which is fair. But It would be better if we could start writing new tests following a better pattern.
This applies to all providers
There was a problem hiding this comment.
That makes sense, swapping over to ControlPlaneSpec and WorkersSpec tests instead for all providers
eks-distro-bot
added
size/M
raymond-zhang00
force-pushed
the
add-docker-upgrade-rollout-strategy
branch
from
b79b377 to
78895d7
Compare
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: raymond-zhang00 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Issue #, if available:
#6719
Description of changes:
Adding UpgradeRolloutStrategy knobs for workers and control plane to docker provider
Testing (if applicable):
Updated unit tests.
Documentation added/planned (if applicable):
Planning on adding docs on knobs for other providers following the Tinkerbell upgrade strategy format.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.